Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented redstone #739

Draft
wants to merge 94 commits into
base: master
Choose a base branch
from
Draft

Implemented redstone #739

wants to merge 94 commits into from

Conversation

JustTalDevelops
Copy link
Member

@JustTalDevelops JustTalDevelops commented Feb 1, 2023 •
edited
Loading

todo (components):

  • redstone comparators
  • daylight sensors
    • requires light updates
  • pressure plates
  • target block
  • trapped chest
  • tripwire & tripwire hooks
  • dispensers
  • doors + iron doors
  • animated skulls
  • fence gates
  • hoppers
  • trapdoors + iron trapdoors
  • sculk sensors

todo (functionality):

  • torch burnout
  • repeater locking
  • comparators
  • saving scheduled updates

todo (bugs):

  • waterlogged repeaters triggering updates by water
  • sticky piston item drop gives normal piston

TwistedAsylumMC and others added 30 commits July 28, 2022 18:22
@TwistedAsylumMC
block: Start of a redstone implementation
5718d14
@TwistedAsylumMC
main.go: Use entity.DirectionVector()
a0f3b30
@TwistedAsylumMC
Merge branch 'master' into feature/redstone
1885828
@JustTalDevelops
block/redstone_dust.go: Various improvements.
0261190
@JustTalDevelops
block/redstone_dust.go: Allow any side on the Y axis.
9d95a78
@JustTalDevelops
block/redstone_dust.go: Removed redundant check.
f0d95ec
@JustTalDevelops
block/redstone_dust.go: Various improvements.
ab2ac47
@JustTalDevelops
Merge branch 'master' into feature/redstone
2858c6b 
# Conflicts:
#	main.go
#	server/block/register.go
@JustTalDevelops
block/redstone_dust.go: Fix disabled emitters check.
1aee785
@JustTalDevelops
block/redstone.go: Started implementation of non-locational redstone …
9004e99 
…wires. (based off of RedstoneWireTurbo and MCHPRS)
@JustTalDevelops
block/redstone_wire.go: Various fixes.
bfa7190
@JustTalDevelops
block/redstone_wire.go: Avoid unnecessary block updates.
62c6840
@JustTalDevelops
block/redstone_lamp.go: type lol
d1f2c6a
@JustTalDevelops
block/redstone_wire.go: Also update surrounding redstone on break.
e480b61
@JustTalDevelops
block/redstone_wire.go: And on place!
8357d63
@JustTalDevelops
block: Documented redstone related components.
5f33b8a
@JustTalDevelops
block/redstone_torch.go: broken redstone torch implementation lol
849ecb0
@JustTalDevelops
block/redstone_torch.go: dont invert facing
2d8f704
@JustTalDevelops
block/redstone_torch.go: power output kinda fixed?
eb00f59
@JustTalDevelops
block/redstone_torch.go: i think it works (mostly)
3bc6524
@JustTalDevelops
block/redstone_torch.go: Add a TODO for burnout.
93a369b
@JustTalDevelops
block/redstone_repeater.go: repeaters... kinda
6a670c0
@JustTalDevelops
block/redstone_repeater.go: oops
0d2643f
@JustTalDevelops
block/redstone_repeater.go: oops v3
3bac09d
@JustTalDevelops
block/redstone.go: ok it actually works !!
d1e18f2
@JustTalDevelops
block/redstone.go: Use the correct update order + pass correct face i…
88ad785 
…nto updateDirectionalRedstone.
@JustTalDevelops
block/redstone_wire.go: Implement RedstoneUpdater.
89decae
@JustTalDevelops
block: Various improvements to redstone, also implemented nonfunction…
e85fc68 
…al comparators.
@DaPigGuy
block: removed unused var
f163f7a
@JustTalDevelops
main.go: Run a pprof HTTP server.
b41f4d5
DaPigGuy and others added 28 commits February 1, 2023 20:20
@DaPigGuy
block/jukebox.go: update redstone power on break
517046d
@DaPigGuy
block/observer.go: implement observers
87779b6
@DaPigGuy
block/observer.go: "fix" Y-axis facing observer placement
47a32f6
@JustTalDevelops
block: Added slime.
4311b8e
@JustTalDevelops
Merge remote-tracking branch 'origin/feature/redstone' into feature/r…
ddff350 
…edstone
@DaPigGuy
block/redstone.go: prevent CI failure
89e9cfb
@JustTalDevelops
world/world.go: Pass block state to ScheduleBlockUpdate.
1d0043f
@JustTalDevelops
block/piston_resolver.go: Glazed terracotta can't be pulled.
feee4f0
@JustTalDevelops
world: Remove commented code.
5306c25
@JustTalDevelops
block/redstone.go: Implemented a RedstoneBlocking interface.
5991930
@JustTalDevelops
block/redstone.go: Implemented a PistonUpdater interface.
a960f80
@JustTalDevelops
world/world.go: Reverted scheduled update changes.
9dd470d 
(this caused too many issues than I anticipated!)
@JustTalDevelops
block: Implemented droppers.
9905a68
@JustTalDevelops
block/dropper.go: Simplified logic.
4c08c32
@JustTalDevelops
block/dropper.go: Various fixes.
f6e1612
@JustTalDevelops
Merge branch 'master' into feature/redstone
8c4c7c2
@JustTalDevelops
go.mod, go.sum: Updated dependencies.
6eae8f7
@DaPigGuy
block/jukebox.go: cleanup
786d38c
@JustTalDevelops
block/dropper.go: Revert changes.
0ad69b3 
We can't use RemoveItem without it always removing the first instance which technically isn't vanilla behaviour.
@JustTalDevelops
Merge remote-tracking branch 'origin/feature/redstone' into feature/r…
6d88883 
…edstone
@JustTalDevelops
block: Implemented (non-functional, for now) hoppers.
2186d15
@JustTalDevelops
Merge branch 'master' into feature/redstone
f373a25
@JustTalDevelops
block/dropper.go: Dispense particles.
95a1254
@JustTalDevelops
Merge remote-tracking branch 'origin/feature/redstone' into feature/r…
86b7414 
…edstone
@JustTalDevelops
block/hopper.go: Item extraction.
37448db
@JustTalDevelops
block/hopper.go: Abstracted custom extractables into their own interf…
a5274d9 
…ace.
@JustTalDevelops
block/hopper.go: Item entity extraction.
05c4c09
@JustTalDevelops
block/hopper.go: Waterlogging.
a2ac369
@RestartFU
Copy link
Contributor

I feel like wanting to have EVERY single feature done and ready before wanting to merge anything would make it impossible for redstone to ever be implemented in dragonfly

in my opinion, as long as there are no bugs, it should get merged.
if sander and the rest of the team can agree on this, I volunteer myself to refactor and update the current implementation of redstone, test and make sure that no current feature has any bugs

@xNatsuri xNatsuri mentioned this pull request Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustTalDevelops @RestartFU @TwistedAsylumMC @DaPigGuy